Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup unrelated classes when rooting (GSI-720) #34

Merged
merged 5 commits into from
May 15, 2024
Merged

cleanup unrelated classes when rooting (GSI-720) #34

merged 5 commits into from
May 15, 2024

Conversation

KerstenBreuer
Copy link
Contributor

@KerstenBreuer KerstenBreuer commented Apr 25, 2024 •
edited
Loading 

... from schemapack.

@KerstenBreuer KerstenBreuer force-pushed the feature/strip_schemapack_GSI-720 branch from 8c02ce0 to c67eee0 Compare April 25, 2024 12:46
@KerstenBreuer KerstenBreuer changed the base branch from feature/fix_comment_handling_GSI-718 to main April 25, 2024 12:46
@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9081494569

Details

  • 36 of 38 (94.74%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 94.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/schemapack/_internals/isolate.py 22 24 91.67%
Totals Coverage Status
Change from base Build 8849056656: -0.1%
Covered Lines: 1057
Relevant Lines: 1119
💛 - Coveralls

sbilge
sbilge requested changes May 10, 2024
View reviewed changes
Copy link
Member

@sbilge sbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Only a minor comment for a typo fix.

examples/schemapack/valid/unrelated_classes_rooted.schemapack.yaml Outdated Show resolved Hide resolved
@KerstenBreuer KerstenBreuer requested a review from sbilge May 13, 2024 13:47
lkuchenb
lkuchenb approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@lkuchenb lkuchenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KerstenBreuer I've not done a review myself but @sbilge's concern was addressed, so I've run the template update and conflict resolution.

@KerstenBreuer
Copy link
Contributor Author

Great, thank you

@KerstenBreuer KerstenBreuer merged commit 785a3ee into main May 15, 2024
4 checks passed
@KerstenBreuer KerstenBreuer deleted the feature/strip_schemapack_GSI-720 branch May 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbilge sbilge sbilge approved these changes

@lkuchenb lkuchenb lkuchenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KerstenBreuer @coveralls @lkuchenb @sbilge