Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Accept Keymaps #47

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jhonnyV-V
Copy link

@jhonnyV-V jhonnyV-V commented Feb 22, 2025

I tried to make the key maps configurable using the g:llama_config object, the default key binds are the same

this is my first time working with vimscript, so I have no idea how bad this pr code is, if there is a better way to do this or if this is "good enough", that said any feedback or improvement is appreciated

this pr should address the issue #34

@jhonnyV-V jhonnyV-V force-pushed the chore_configurable_keymaps branch from 700dfb1 to 88980ff Compare February 22, 2025 16:28
Copy link
Collaborator

@Frefreak Frefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could also have the "trigger" key configurable (<C-F>). That could leave to another PR though.

@jhonnyV-V
Copy link
Author

It would be nice if we could also have the "trigger" key configurable (<C-F>). That could leave to another PR though.

I tried using the same method, but it did not work, not really sure why

fix spacing issues in doc example and trailing spaces
@jhonnyV-V jhonnyV-V force-pushed the chore_configurable_keymaps branch 2 times, most recently from 840befb to 6085c68 Compare February 23, 2025 15:11
@jhonnyV-V jhonnyV-V force-pushed the chore_configurable_keymaps branch from 6085c68 to 18a1248 Compare February 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants