testemGH-1119: Migrated all instanceof Array checks to use `Array.i…

…sArray`.
getsnoopy · May 3, 2017 · 60684dc · 60684dc
1 parent b3bc989
commit 60684dc
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/utils/browser-args.js b/lib/utils/browser-args.js
@@ -36,7 +36,7 @@ module.exports = {
     return new Validation();
   },
   dedupeBrowserArgs: function(browserName, browserArgs) {
-    if (!browserName || !(browserArgs instanceof Array)) { return; }
+    if (!browserName || !Array.isArray(browserArgs)) { return; }
 
     var argHash = {};
 
@@ -64,7 +64,7 @@ module.exports = {
 
       patchArgs = validation.knownBrowser.args;
 
-      if (patchArgs instanceof Array) {
+      if (Array.isArray(patchArgs)) {
         validation.knownBrowser.args = browserArgs.concat(validation.knownBrowser.args);
       } else if (typeof patchArgs === 'function') {
         validation.knownBrowser.args = function() {
@@ -83,7 +83,7 @@ module.exports = {
     }
   },
   validate: function(browserName, browserArgs, knownBrowsers) {
-    if (!browserName || !browserArgs || !(knownBrowsers instanceof Array) ||
+    if (!browserName || !browserArgs || !(Array.isArray(knownBrowsers)) ||
       !knownBrowsers.length) { return; }
 
     var i;
@@ -114,13 +114,13 @@ module.exports = {
     var i;
     var len;
 
-    if (typeof browserArgs !== 'string' && !(browserArgs instanceof Array)) {
+    if (typeof browserArgs !== 'string' && !(Array.isArray(browserArgs))) {
       validation.messages.push('Type error: ' + browserName +
         '\'s "args" property should be a string or an array');
     } else if (typeof browserArgs === 'string' && !browserArgs.trim()) {
       validation.messages.push('Bad value: ' + browserName +
         '\'s "args" property should not be empty');
-    } else if (browserArgs instanceof Array) {
+    } else if (Array.isArray(browserArgs)) {
       len = browserArgs.length;
 
       if (len) {