Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filter offset for attribute values API #6667

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Implement filter offset for attribute values API #6667

wants to merge 6 commits into from
+141 −59

Conversation

xurui-c
Copy link
Member

@xurui-c xurui-c commented Dec 12, 2024 •
edited
Loading

https://github.com/getsentry/eap-planning/issues/115

Already did it for attribute names API, doing it for attribute values API in this PR. Also sorted attribute values alphabetically in response so filter offset can be implemented

@xurui-c xurui-c force-pushed the rachel/attributeValuesFilterOffset branch from 7844d60 to 4026433 Compare December 12, 2024 23:46
@xurui-c xurui-c changed the title c Implement filter offset for attribute values API Dec 12, 2024
@xurui-c xurui-c marked this pull request as ready for review December 12, 2024 23:53
@xurui-c xurui-c requested review from a team as code owners December 12, 2024 23:53
@xurui-c xurui-c marked this pull request as draft December 17, 2024 06:01
@xurui-c xurui-c force-pushed the rachel/attributeValuesFilterOffset branch from 5f3026a to b25a4b3 Compare January 6, 2025 19:22
@xurui-c xurui-c force-pushed the rachel/attributeValuesFilterOffset branch from 9a63a0e to 66cf01c Compare January 6, 2025 19:49
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2734 1 2733 6
View the top 1 failed tests by shortest run time 
tests.web.rpc.v1.test_endpoint_trace_item_attribute_names.TestTraceItemAttributeNames::test_page_token_offset_filter
Stack Traces | 0.288s run time 
Traceback (most recent call last):
  File ".../rpc/v1/test_endpoint_trace_item_attribute_names.py", line 269, in test_page_token_offset_filter
    assert res.WhichOneof("page_token") == "filter_offset"
ValueError: Expected a oneof name, but got field name page_token.

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@xurui-c xurui-c marked this pull request as ready for review January 6, 2025 21:08
kylemumma
kylemumma reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@kylemumma kylemumma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is that your test could be using offset by default rather than filter_offset

snuba/web/rpc/v1/trace_item_attribute_values.py Show resolved Hide resolved
tests/web/rpc/v1/test_trace_item_attribute_values_v1.py Outdated Show resolved Hide resolved
tests/web/rpc/v1/test_trace_item_attribute_values_v1.py Show resolved Hide resolved
@xurui-c xurui-c force-pushed the rachel/attributeValuesFilterOffset branch from 447e323 to e1e5eae Compare January 8, 2025 21:11
@xurui-c xurui-c requested review from kylemumma and volokluev January 8, 2025 21:50
@xurui-c xurui-c force-pushed the rachel/attributeValuesFilterOffset branch from e1e5eae to 7e58b8b Compare January 9, 2025 00:41
@xurui-c xurui-c requested a review from kylemumma January 9, 2025 00:42
kylemumma
kylemumma approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@kylemumma kylemumma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests pass

@xurui-c xurui-c force-pushed the rachel/attributeValuesFilterOffset branch from 7e58b8b to 0fb48b0 Compare January 9, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylemumma kylemumma kylemumma approved these changes

@volokluev volokluev Awaiting requested review from volokluev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xurui-c @volokluev @kylemumma