fix(integrations): Add partial json support to streams #3674
+83
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds partial json to the content block when streaming.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3674 +/- ##
==========================================
- Coverage 80.20% 80.14% -0.06%
==========================================
Files 140 140
Lines 15412 15414 +2
Branches 2593 2594 +1
==========================================
- Hits 12361 12354 -7
- Misses 2206 2220 +14
+ Partials 845 840 -5
|
kwnath
commented
Oct 21, 2024
sentry_sdk/integrations/anthropic.py
Outdated
| @@ -21,8 +21,7 @@ | |||
| raise DidNotEnable("Anthropic not installed") | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import Any, AsyncIterator, Iterator | |||
| from sentry_sdk.tracing import Span | |||
| pass | |||
There was a problem hiding this comment.
I'll review this PR again, my linter removed these.
antonpirker
previously approved these changes
Nov 21, 2024
|
@kwnath could you fix the failing tests please? Thanks! |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I actually forgotten to add the most crucial in PR where we wanted to add support for
partial_jsonin tool calling when streaming. This PR fixes that.cc @antonpirker apologies for this!