Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize imports in tasks.py.jinja2 #3387

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

gagath
Copy link
Contributor

@gagath gagath commented Aug 4, 2024

When opening the generated tasks.py file with a Python linter enabled, some imports will be marked as unecessary depending on the options passed to pelican-quickstart.

Add if statements around the optional imports so they are used only when necessary.

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools

When opening the generated tasks.py file with a Python linter enabled,
some imports will be marked as unecessary depending on the options
passed to pelican-quickstart.

Add if statements around the optional imports so they are used
only when necessary.
@justinmayer justinmayer changed the title tasks.py.jinja2: optimize imports Optimize imports in tasks.py.jinja2 Sep 12, 2024
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the enhancement, Agathe! 🏅

@justinmayer justinmayer merged commit 84f2995 into getpelican:main Sep 12, 2024
16 checks passed
@gagath gagath deleted the optimize-taskspy-template branch September 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants