Remove ifconfig Sphinx extension from docs
#3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `matplotlib` installed, Sphinx output says that social cards cannot be generated.
Originally added in #815, something about this seems to be causing an obscure ReadTheDocs build error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added in #815, something about this configuration seems to be causing an obscure ReadTheDocs build error. Plus, it seems ReadTheDocs has since added this version-warning functionality as a beta feature. After merging this PR, if the latter built-in beta feature proves to deliver similar functionality, we could consider removing the
last_stablevariable and any other related changes that are no longer relevant.This PR also adds
matplotlibto our documentation package dependencies. Without it installed, Sphinx output says that social cards cannot be generated.