Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pre-commit to run ruff and ruff-format with fixes #3311

Merged
merged 2 commits into from
May 30, 2024

Conversation

boxydog
Copy link
Contributor

@boxydog boxydog commented May 30, 2024

Pull Request Checklist

Resolves: 3216

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools

@boxydog boxydog force-pushed the fix_3216_two_commits branch from 7ff9014 to 0efc48f Compare May 30, 2024 14:05
@boxydog boxydog force-pushed the fix_3216_two_commits branch from 0efc48f to 6d8597a Compare May 30, 2024 14:08
@boxydog boxydog mentioned this pull request May 30, 2024
1 task
@boxydog
Copy link
Contributor Author

boxydog commented May 30, 2024

FYI:

This changes 26 files, while #3239 changes 27. The difference is I didn't port over the log.py change:

__all__ = ["init", "console"]

That change is valid IMO, but isn't part of the ruff fixing. I had just made that change because PyCharm pointed out that the console symbol was being used but not exported.

@justinmayer justinmayer changed the title Change pre-commit to run ruff and ruff-format with fixes Change pre-commit to run ruff and ruff-format with fixes May 30, 2024
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for all your work on this, @boxydog! 🌟

@justinmayer justinmayer merged commit 8d8feb6 into getpelican:master May 30, 2024
15 checks passed
@boxydog boxydog deleted the fix_3216_two_commits branch May 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants