Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_deprecated_attribute test failure #3310

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix test_deprecated_attribute test failure #3310

merged 1 commit into from
May 30, 2024

Conversation

boxydog
Copy link
Contributor

@boxydog boxydog commented May 29, 2024

Pull Request Checklist

Resolves: #3309

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools

@boxydog
Copy link
Contributor Author

boxydog commented May 29, 2024

See discussion at #3239 (comment)

@boxydog boxydog mentioned this pull request May 29, 2024
Closed
1 task
@justinmayer justinmayer changed the title Fix test_deprecated_attribute failures in github tests Fix test_deprecated_attribute test failure May 30, 2024
@justinmayer
Copy link
Member

Many thanks to @stanislavlevin and @boxydog for fixing this test. Much appreciated!

@justinmayer justinmayer merged commit f0b6e87 into getpelican:master May 30, 2024
15 checks passed
@boxydog boxydog deleted the fix_3309 branch May 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_deprecated_attribute fails on some platforms
2 participants
@boxydog @justinmayer