Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error logging if a plugin refuses to load #3276

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Better error logging if a plugin refuses to load #3276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0beb81
Better error logging if a plugin refuses to load
MinchinWeb Jan 14, 2024
f1f2cec
Warning/error logging: be explicit in how the `stacklevel` variable i…
MinchinWeb Jan 27, 2024
1f14606
On failing to load a plugin, show the stacktrace is pelican is run in…
MinchinWeb Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pelican/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def init_plugins(self):
plugin.register()
self.plugins.append(plugin)
except Exception as e:
logger.error("Cannot register plugin `%s`\n%s", name, e)
logger.error("Cannot register plugin `%s`\n%s", name, e, stacklevel=3)
print(e.stacktrace)
avaris marked this conversation as resolved.
Show resolved Hide resolved

self.settings["PLUGINS"] = [get_plugin_name(p) for p in self.plugins]

Expand Down
8 changes: 6 additions & 2 deletions pelican/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,16 @@ class FatalLogger(LimitLogger):
# adding `stacklevel=2` means that the displayed filename and line number
# will match the "original" calling location, rather than the wrapper here
def warning(self, *args, **kwargs):
super().warning(*args, stacklevel=2, **kwargs)
if "stacklevel" not in kwargs.keys():
kwargs["stacklevel"] = 2
super().warning(*args, **kwargs)
avaris marked this conversation as resolved.
Show resolved Hide resolved
if FatalLogger.warnings_fatal:
raise RuntimeError("Warning encountered")

def error(self, *args, **kwargs):
super().error(*args, stacklevel=2, **kwargs)
if "stacklevel" not in kwargs.keys():
kwargs["stacklevel"] = 2
super().error(*args, **kwargs)
if FatalLogger.errors_fatal:
raise RuntimeError("Error encountered")

Expand Down