Add GH pages action to fix file permissions #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaris
reviewed
Nov 18, 2023
|
This fix seems fine to me 👍 If upload-pages-artefact chokes on certain file permissions in the output directory, I see no reason why the workflow shouldn't fix those permissions to ensure that doesn't happen |
avaris
approved these changes
Nov 18, 2023
justinmayer
changed the title
justinmayer
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
Thanks to @vbharadwaj-bk for the enhancement and to @avaris and @seanh for reviewing. 🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Resolves: #3244
Adds a Github action that fixes file permissions before uploading (such as cache files created by Pelican Webassets if the cache is not disabled). Raises a warning for each file without proper permissions.