Better error message on bad slug

getpelican · Dec 13, 2023 · 902640e · 902640e
1 parent bc54862
commit 902640e
Showing 1 changed file with 30 additions and 9 deletions.
diff --git a/pelican/generators.py b/pelican/generators.py
@@ -574,9 +574,16 @@ def generate_tags(self, write):
                     page_name=tag.page_name,
                     all_articles=self.articles,
                 )
-            except RuntimeError as e:
-                logger.error('Trying to write Tag page for "%s".' % (tag))
-                raise e
+            except RuntimeError:
+                if not tag.slug:
+                    logger.warning(
+                        'Tag "%s" has an invalid slug; skipping writing tag page...',
+                        tag,
+                    )
+                    continue
+                else:
+                    logger.error('Failed to write Tag page for "%s".', tag)
+                    raise
 
     def generate_categories(self, write):
         """Generate category pages."""
@@ -597,9 +604,16 @@ def generate_categories(self, write):
                     page_name=cat.page_name,
                     all_articles=self.articles,
                 )
-            except RuntimeError as e:
-                logger.error('Trying to write Category page for "%s".' % (cat))
-                raise e
+            except RuntimeError:
+                if not cat.slug:
+                    logger.warning(
+                        'Category "%s" has an invalid slug; skipping writing category page...',
+                        cat,
+                    )
+                    continue
+                else:
+                    logger.error('Failed to write Category page for "%s".', cat)
+                    raise
 
     def generate_authors(self, write):
         """Generate Author pages."""
@@ -620,9 +634,16 @@ def generate_authors(self, write):
                     page_name=aut.page_name,
                     all_articles=self.articles,
                 )
-            except RuntimeError as e:
-                logger.error('Trying to write Author page for "%s".' % (aut))
-                raise e
+            except RuntimeError:
+                if not aut.slug:
+                    logger.warning(
+                        'Author "%s" has an invalid slug; skipping writing author page...',
+                        aut,
+                    )
+                    continue
+                else:
+                    logger.error('Failed to write Author page for "%s".', aut)
+                    raise
 
     def generate_drafts(self, write):
         """Generate drafts pages."""