-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds pricing for transform mrna_diffusion_generate
#4
base: main
Are you sure you want to change the base?
Conversation
examples.ts
Outdated
transform: Transforms.MRNA_DIFFUSION_GENERATE, | ||
unmaskings_per_step: 3, | ||
five_utr: | ||
"ATGG<MASK><MASK><MASK><MASK>MKL<MASK><MASK><MASK><MASK><MASK><MASK><MASK>MKL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this has to run but there are AA characters in this that will fail (MKL). This has to be A/T/G/C. Also not sure where this is hitting in the API: the ginkgo python AI client takes for consistency but the original model takes [MASK].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good catch, I just copy-pasted something without checking, fixed now.
Re. your question, The pricing model is run on user requests before the request is sent to our servers. It doesn't fully validate sequences, the critical things we want from it is that it implements the right formula and parses correctly any request generated by the python client (hence here).
modelPricing.ts
Outdated
export type MRNADiffusionGenerateParams = { | ||
transform: Transforms.MRNA_DIFFUSION_GENERATE; | ||
unmaskings_per_step: number; | ||
model: ModelOptions.mrna_foundation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this pricing model taking into account num_samples
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha the most important commit didn't go through on Friday, just added it back, this is the implementation.
No description provided.