This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Minor wallet improvements #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
requested review from
da-kami and
klochowicz
and removed request for
da-kami
bonomat
force-pushed
the
wallet-manual-sync
branch
from
b0307a8 to
d0ccadb
Compare
da-kami
approved these changes
Jun 6, 2022
| @@ -350,6 +351,11 @@ where | |||
| }) | |||
| .await? | |||
| } | |||
|
|
|||
| pub async fn sync_wallet(&self) -> Result<()> { | |||
| self.wallet_actor.send(wallet::Sync).await?; | |||
There was a problem hiding this comment.
My understanding is, that this is a blocking send that we await so the UI gets feedback if the sync is done.
Not sure how the routes will behave if a user triggers some other actions while waiting for the wallet to sync, but I don't think it matters much.
I was thinking if it would make sense to make this send_async, but I don't think we can easily achieve this in a good way, and while the wallet is syncing we should not really trigger actions anyway. So I think this is fine :)
There was a problem hiding this comment.
Just tried it: it's not blocking, you can go out of the wallet. I was able to open a position but I think the sync was already done by that time :)
|
bors r+ |
|
Merge conflict. |
Allows us to see when sync is being started
We don't have it in the frontend so no need to have the endpoint exported.
Now that we can trigger the wallet sync manually through the UI we can sync less often. This - reduces load from ourselves because syncing is a long running process - reduces load from the infrastructure we are using For now we sync every 3 minutes. This has been chosen because 2 is an impossible number: https://wiki.c2.com/?TwoIsAnImpossibleNumber
bonomat
force-pushed
the
wallet-manual-sync
branch
from
d0ccadb to
867915a
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2022
2172: Minor wallet improvements r=bonomat a=bonomat Fixes #2158 Minor UI change: Maker UI: <img width="486" alt="image" src="https://user-images.githubusercontent.com/224613/172093037-b1dfc492-9789-4524-a781-afc77c9de069.png"> Taker UI: <img width="750" alt="image" src="https://user-images.githubusercontent.com/224613/172093106-79a31577-4d09-4e33-9dbb-e2f3a51d3a08.png"> While syncing: <img width="803" alt="image" src="https://user-images.githubusercontent.com/224613/172093127-a58e6f27-44f9-499d-866b-55dcfa2243f6.png"> Co-authored-by: Philipp Hoenisch <[email protected]>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2022
2172: Minor wallet improvements r=bonomat a=bonomat Fixes #2158 Minor UI change: Maker UI: <img width="486" alt="image" src="https://user-images.githubusercontent.com/224613/172093037-b1dfc492-9789-4524-a781-afc77c9de069.png"> Taker UI: <img width="750" alt="image" src="https://user-images.githubusercontent.com/224613/172093106-79a31577-4d09-4e33-9dbb-e2f3a51d3a08.png"> While syncing: <img width="803" alt="image" src="https://user-images.githubusercontent.com/224613/172093127-a58e6f27-44f9-499d-866b-55dcfa2243f6.png"> Co-authored-by: Philipp Hoenisch <[email protected]>
|
Build failed: |
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2158
Minor UI change:
Maker UI:
Taker UI:
While syncing: