adds support for gmx:anchor in gmd:identifier #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvgenuchten
force-pushed
the
anchor-in-identifier
branch
from
16ac5cb to
a8b0a2c
Compare
pvgenuchten
force-pushed
the
anchor-in-identifier
branch
5 times, most recently
from
06261a5 to
83e8568
Compare
|
the gmx:Anchor element typically contains a uri and a label, in some cases both values are stored as
in the case of uricode it probably makes more sense to store a single value. Also because the type is array, adding uricode = [a,b,c] and uricode_url = [a1,b1,c1] would not make much sense. |
geographika
reviewed
Oct 8, 2024
tests/test_iso_parsing.py
Outdated
| assert_list(iden.uricode, 1) | ||
| assert iden.uricode[0] == 'https://www.nationaalgeoregister.nl/geonetwork/srv/metadata/f44dac86-2228-412f-8355-e56446ca9933' | ||
|
|
||
| # gmd:pointOfContact/gmd:CI_ResponsibleParty/gmd:organisationName/gmx:Anchor = 'http://standaarden.overheid.nl/owms/terms/Ministerie_van_Defensie' |
There was a problem hiding this comment.
Can these lines be removed (the commented-out lines at the end of this file)?
There was a problem hiding this comment.
Hi Seth, it was a reminder of upcoming work, but I removed it
pvgenuchten
force-pushed
the
anchor-in-identifier
branch
from
83e8568 to
3824231
Compare
|
Thanks @pvgenuchten - CI all passing, and looks good to me - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimizes #946