Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read account names #161

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Read account names #161

wants to merge 7 commits into from

Conversation

juliangums
Copy link

No description provided.

@juliangums juliangums mentioned this pull request Nov 13, 2024
Open
PowerKiKi
PowerKiKi requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this will require adding tests before being merged. An easy to do that is to add the appropriate file in test/data.

src/DTO/NamedAccount.php Outdated

use Genkgo\Camt\Iban;

class NamedAccount extends Account
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not introduce a new class here. The spec defines Acc as type CashAccount25. And CashAccount25 defines an object that has must have an ID (IBAN or Othr), and may have a name. Thus the name property must be added on the existing IbanAccount

@juliangums
Copy link
Author

@PowerKiKi I've done those things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerKiKi PowerKiKi PowerKiKi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangums @PowerKiKi