Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rollback stufe 3 interactions encounter+patient ptdata 1419 #226

Open
wants to merge 21 commits into
base: TC_3.0.5
Choose a base branch
from
Open

Feature/rollback stufe 3 interactions encounter+patient ptdata 1419 #226

wants to merge 21 commits into from

Conversation

f-peverali
Copy link
Contributor

@f-peverali f-peverali commented Jan 3, 2025 •
edited
Loading

Contributor Pull Request

Description

rollback auf commits that deleted functionality for Paitent and Encounter interactions - (git revert for cc6972d and 27aaa17)

Motivation and Context

  • Problem: Durch die Entfernung von Anforderungen die Abfragen von Patienten- und Encounter-Ressourcen betreffend, sind die Herstellung von Dokumentenkontexten zu besagten Ressourcen in der Regel nicht mehr möglich.
  • Lösung: Rollback der Änderung - wodurch die entsprechenden Suchparameter wieder in die Spezifikation aufgenommen werden.

How has this been tested?

Snippets or Screenshots (if necessary):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this IG / specification.
  • My change requires a change to the documentation or narrative (intend) of the IG.
  • I have already updated the documentation / narrative (intend) accordingly.

Reviewer / Quality Assurance Checklist

  • The Present PR does not need a thorough review process, due to brevity, low complexity or because it represents a rather minor change; otherwise go trough the list! ... and read the linked manual, if you did not do it yet!

content review steps (based on Best Practice IG Germany)

formal intellectual review steps of Implementation Guide

  • no formal review needed

  • proofreading for orthography

  • there are no (critical) validation Errors in the CI pipeline

    • inspected and no critical errors found(In the "github action view" -> Option button -> "View raw logs") - possibly list non-critical below

  • skim reading for correct rendering of IG (possibly using IG-grep of string String like "Could not render")

automated review steps:

  • no formal review needed
  • check IG-pages for broken links (possibly using plug-in)
  • [ ]

For reviewers

You migh use this: https://conventionalcomments.org/

simoneOnFhir

This comment was marked as resolved.

Sign in to view

f-peverali
f-peverali commented Jan 24, 2025
View reviewed changes
Copy link
Contributor Author

@f-peverali f-peverali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: Stand ist geeignet für review in der AG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneOnFhir simoneOnFhir simoneOnFhir left review comments

@nikohl-de nikohl-de Awaiting requested review from nikohl-de

@alexey-tschudnowsky alexey-tschudnowsky Awaiting requested review from alexey-tschudnowsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-peverali @simoneOnFhir