Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find gz-launch without major version #2

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebo-tooling/release-tools#1244, companion to gazebosim/gz-launch#286

Summary

The major version is removed from the cmake project name for gz-launch in gazebosim/gz-launch#286, so update the find_package call accordingly.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters changed the base branch from ci_matching_branch/bump_jetty_gz-jetty to main January 23, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants