Remove global path exclusion state #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the path exclusion singleton pattern entirely.
This was a hack to avoid building exclude patterns in the Rust extension once per file, but now we almost always do the full file traversal in Rust (modularity report building and the 'external' portion of
tach reportare the remaining exceptions).This is being addressed now because we are starting to hit timing-related flakiness with the Rust test suite due to concurrency and the global exclude state.
Edit: The test flakiness was more directly caused by the other, intentional source of global state: interrupt handling. This is also addressed in this PR by disabling interrupts when compiling for tests, and using a shadow, real implementation specifically for testing the interrupts themselves.