Django fkey detection #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdoyle
force-pushed
the
django-fkey-detection
branch
from
1c49011 to
cbb32e3
Compare
emdoyle
changed the base branch from
generalize-processors
to
generalize-imports
emdoyle
force-pushed
the
django-fkey-detection
branch
from
57f8105 to
d240fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plugs into the 'processing' stage of the
tach checkpipeline.In addition to extracting imports from the AST, this PR introduces a specialized visitor which finds
ForeignKeycalls, and extracts thetofield when it is a string literal. This is useful because it may avoid a direct import, but still create a cross-module dependency.To support this, there is also an AST visitor which runs once up-front to extract the
INSTALLED_APPSfrom the configured Django settings module. This allows us to resolve the string literals used inForeignKey, which are typically of the form<app_label>.<model>.