Retroplayer debug #134
Closed
Retroplayer debug #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Estuary] addonsettings - fix list
[Estuary] Fix order of TVShowTitle and Title Leia
…leia [Leia][PVR] Fix group manager crash when adding a new group. Closes xbmc#16079.
…-18-v2 [Estuary] fix scrollbar in skinsettings
[Leia][PVR] Create EPG when a PVR channel has been dynamically added at runtime
…tDevices Signed-off-by: Sam Nazarko <[email protected]>
Adds two-finger right swipe for access to the blade menu on touchscreens.
Adds blade menu access through long right-click. Adds right click as a way to exit the context menu without selecting anything.
[Estuary] fix search button on side menu
…es-leia [PVR] Prevent concurrent updates for all pvr windows.
[video] Add support for HEVC to CDVDDemuxClient::GetStreamCodecName.
…tep 1: directory listings.
[PVR] Separate GUI from PVR core: remove CFileItem usage from core: step 1: directory listings.
Keymap backport
Fix blank dialog when Joystick X key hit and there is no visualisation - Backport
[PlaylistPlayer] Resolve plugin paths to fill the item infotag
RendererMediaCodecSurface: Announce vertical shift as well
Bump for 18.5 final
Fixes black screen with RGB emulators on RPi.
There are OpenGL errors when glVertexAttribute is called in CGUITextureGL::End after starting up media (only tested on RetroPlayer, but it probably happens on VideoPlayer as well). The cause of the error is that there's no VAO bound (or rather, VAO 0 is bound). Not sure why rendering has worked up to this point. This change asks the rendering context to apply any state necessary before rendering (part of which is binding the VAO). It also fixes a GUI freeze issue on RetroPlayer. This is tested with GL core 4.6 profile, not sure about older or compatibility profiles. Running apitrace doesn't show the related GL errors after this change.
Thanks to Zach Morris for providing this awesome add-on.
This imports several shader presets from libretro common at commit 187c161 (https://github.com/libretro/common-shaders/tree/187c161).
Game items ending in disk image extensions are currently played using VideoPlayer instead of RetroPlayer. This results in a brief buffering dialog, and then the player exits to the previous window.
The prior behavior was kept as a fallback. If the fallback is used, a deprecation warning is logged.
* Add `<f5>ReloadSkin()</f5>` to keymap.xml for debugging * Build binary add-ons in Debug mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
What is the effect on users?
Screenshots (if appropriate):
Types of change
Checklist: