Add SizeName property to label to control text size

[dweymouth]

Description:

Allows for controlling the text size of a Label widget. Especially useful with selection support landing in 2.6 as the only other way to customize the size of selectable text would be a ThemeOverride container, which is heavyweight and verbose.

This mirrors the API that already exists for Hyperlink sizing.

Fixes #5561

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Public APIs match existing style and have Since: line.

[coveralls]

coverage: 62.313% (-0.09%) from 62.402%
when pulling f60004d on dweymouth:label-style
into 4cd00b5 on fyne-io:develop.

[andydotxyz]

I think this really needs some tests, make sure the label is scaling appropriately, updates on change and that the selection follows it...

[andydotxyz]

Thanks for adding a test.

I'm surprised that the images are the same size - does this indicate that the MinSize function is not updating, or that the test isn't respecting it?

I assume that a label with larger or smaller text would have a MinSize adjustment accordingly?

[dweymouth]

Thanks for adding a test.

I'm surprised that the images are the same size - does this indicate that the MinSize function is not updating, or that the test isn't respecting it?

I assume that a label with larger or smaller text would have a MinSize adjustment accordingly?

The label's min size is larger, the test window just wasn't respecting it - pushed an update to the test to just use w.SetContent again to make sure the window expands to respect the new min size.

[andydotxyz]

Sweet thanks

[ErikKalkoken]

tyvm for implementing this feature!

sorry for my late comment (literally just saw this). But wouldn't it be better to limit the user to text-related sizes? e.g. by defaulting to normal size when a non-text related size is specified?

[dweymouth]

tyvm for implementing this feature!

sorry for my late comment (literally just saw this). But wouldn't it be better to limit the user to text-related sizes? e.g. by defaulting to normal size when a non-text related size is specified?

you mean preventing something like theme.SizeNameInputRadius from being used? That's not possible, at least in a clean way, since both "text-related" and "non-text-related" size names have the same type, and are the same concept at the theme level. This also mirrors the API already on widget.Hyperlink for controlling size as well as what TextSegments in widget.RichText support

[ErikKalkoken]

tyvm for implementing this feature!
sorry for my late comment (literally just saw this). But wouldn't it be better to limit the user to text-related sizes? e.g. by defaulting to normal size when a non-text related size is specified?

you mean preventing something like theme.SizeNameInputRadius from being used? That's not possible, at least in a clean way, since both "text-related" and "non-text-related" size names have the same type, and are the same concept at the theme level. This also mirrors the API already on widget.Hyperlink for controlling size as well as what TextSegments in widget.RichText support

ty for the clarification. did not realize that the RichText and Hyperlink API also allows it and in that regards it makes indeed more sense to keep it the same.