Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SSE with websockets #268

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Replace SSE with websockets #268

wants to merge 1 commit into from

Conversation

fusion44
Copy link
Owner

@fusion44 fusion44 commented Aug 1, 2024 •
edited
Loading

Endpoints:
old: /sse/subscribe
new: /ws

A couple of points:

  • the messages should be the same
  • messages send to the server will be ignored (just replies with "Send only server"). I don't know what the standard is in cases like these.
  • lots of testing needs to be done
  • one of the dependencies causes some headaches due to recent updates
  • some endpoints like /apps/status where removed. I don't think they were in use anyway.

refs #252

@fusion44
feat: replace SSE with a websockets
005f114 
Old: /sse/subscribe
New: /ws

refs #252
@fusion44 fusion44 changed the title implement#252 replace SSE with a websockets 252: replace SSE with a websockets Aug 1, 2024
@fusion44 fusion44 changed the title 252: replace SSE with a websockets Replace SSE with a websockets Aug 1, 2024
@fusion44 fusion44 changed the title Replace SSE with a websockets Replace SSE with websockets Aug 1, 2024
@cstenglein cstenglein mentioned this pull request Aug 15, 2024
Open
@cstenglein cstenglein mentioned this pull request Sep 24, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fusion44