Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types for jsonSerialize #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add return types for jsonSerialize #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
433d1e9
Update Statement.php
arendjantetteroo Dec 12, 2023
46fa933
Update Transaction.php
arendjantetteroo Dec 12, 2023
06e94ae
Update composer.json - minimum php8
arendjantetteroo Dec 12, 2023
285d58e
Fix php8.4 nullable deprecation
arendjantetteroo Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}
],
"require": {
"php": ">=7",
"php": ">=8",
"ext-json": "*"
},
"require-dev": {
Expand Down
2 changes: 1 addition & 1 deletion src/Banking/Statement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Statement implements \JsonSerializable
/**
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): mixed
{
return get_object_vars($this);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Banking/Transaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Transaction implements \JsonSerializable
/**
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): mixed
{
return get_object_vars($this);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Parser/Banking/Mt940.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ class Mt940 extends Banking
* Parse the given string into an array of Banking\Statement objects.
*
* @param string $string
* @param Banking\Mt940\Engine $engine
* @param ?Banking\Mt940\Engine $engine
*
* @return \Kingsquare\Banking\Statement[]
*/
public function parse($string, Banking\Mt940\Engine $engine = null)
public function parse($string, ?Banking\Mt940\Engine $engine = null)
{
if (!empty($string)) {
// load engine
Expand Down