Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just quick fix showBuffering false not working #66

Open
wants to merge 1 commit into
base: 2.0.0
Choose a base branch
from

Conversation

neo725
Copy link

@neo725 neo725 commented Jun 24, 2018

It's my first pr.
and maybe it's not the best way to fix showBuffering not working when i want it to be false.
so, what if i'm wrong, feel free to edit my pr.
hope this helps your code to be better.

@neo725 neo725 changed the title Just quick fix showBuffer not working Just quick fix showBuffering false not working Jun 24, 2018
Copy link
Owner

@frontyard frontyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you retest this change with the latest code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants