Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new configuration variable BUILD_JAIL_SILENTLY #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new configuration variable BUILD_JAIL_SILENTLY #887

wants to merge 1 commit into from

Conversation

yasuhirokimura
Copy link

Add new configuration variable BUILD_JAIL_SILENTLY. If you set it to yes in poudriere.conf, then -s option is passed to make(1) and therefore less messages are displayed when building/installing/updating jail from source tree. It affects only when you use either -b or -m git|svn option of jail command.

@bdrewery
Copy link
Member

bdrewery commented Jul 12, 2021 •
edited
Loading

I think we have too many options as is and complicate the interface. Defaulting to make -s when poudriere -v is not used seems better to me. Git/svn already do that.
Somewhere near the top:

[ $VERBOSE -gt 0 ] || MAKE_CMD="${MAKE_CMD} -s"

@evadot
Copy link
Contributor

evadot commented Jul 13, 2021

I have MAKEWORLDARGS=" -s " in my poudriere.conf for years now so any solution would be fine to me.

@yasuhirokimura
Copy link
Author

I think we have too many options as is and complicate the interface. Defaulting to make -s when poudriere -v is not used seems better to me.

I updated that way.

jail: Add '-s' options to MAKE_CMD by default
460407c 
Add '-s' option to MAKE_CMD unless '-v' option of 'poudriere' is
specified. This means less messages are displayed while
building/installing/updating jail from source tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasuhirokimura @bdrewery @evadot