Add initial GitHub Actions support for lutok #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being done to ensure that lutok can leverage a bit more modern C++ idioms. Signed-off-by: Enji Cooper <[email protected]>
- Rely on pkg-config or pkgconf instead of lua-config when querying lua's build config: lua-config is no longer distributed with many distributions. - Bump the minimum version of lua to 5.3 (the last 5.2 release was in 2015). Signed-off-by: Enji Cooper <[email protected]>
This flag was replaced by `--enable-atf` in 0.5. Signed-off-by: Enji Cooper <[email protected]>
C++14 is now required to build lutok. Remove all pre-C++11 oxbow code. Submitted by: Minsoo Choo <[email protected]> Signed-off-by: Enji Cooper <[email protected]>
ngie-eign
force-pushed
the
add-gh-actions
branch
2 times, most recently
from
31cdb21 to
d618ddf
Compare
This proposed GitHub Actions workflow file runs tests on MacOS and Ubuntu Linux, similar to what is being proposed in freebsd/atf#93 . The delta between this change and the one being made in ATF mostly relates to the additional package dependencies, e.g., Lua, and build permutations, e.g., with and without ATF. Kyua is built from scratch because of issues with dependent packages and runtime linker collisions on both MacOS and Ubuntu. The binary package versions are built against a different version of Lutok, ergo they can have runtime linker collisions. Signed-off-by: Enji Cooper <[email protected]>
ngie-eign
force-pushed
the
add-gh-actions
branch
from
d618ddf to
e037e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed GitHub Actions workflow file runs tests on MacOS and Ubuntu Linux, similar to what is being proposed in freebsd/atf#93 .
The delta between this change and the one being made in ATF mostly relates to the additional package dependencies, e.g., Lua, and build permutations, e.g., with and without ATF.
Kyua is built from scratch because of issues with dependent packages and runtime linker collisions on both MacOS and Ubuntu. The binary package versions are built against a different version of Lutok, ergo they can have runtime linker collisions.
Example run: https://github.com/ngie-eign/lutok/actions/runs/12518992276 .
This PR requires: #27.
CC: @kevemueller