chore(eslint): enable react/forbid-dom-props rule #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The
color-system
component violates this rule so it needs to be updated, but its story needs to be resurrected first in order to test the changes (#66).Checklist:
Update index.md
)This PR enables the
react/forbid-dom-props
rule to disallow inline styles in HTML elements.We already have two ways to style an element: using a CSS stylesheet and using Tailwind classes, so there is no need for inline styles. Inline styles also have high specificity and they will override the rules in our stylesheets (except for rules with
!important
), so they will make debugging CSS more challenging.Ref: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/forbid-dom-props.md
Screenshot
Screenshot of the rule in action: