chore: add testing (#94)

* chore: add testing Co-authored-by: Oliver Eyton-Williams <[email protected]>
freeCodeCamp · Jan 14, 2022 · 4bade20 · 4bade20
1 parent ca9557e
commit 4bade20
Show file tree

Hide file tree

Showing 57 changed files with 8,377 additions and 2,204 deletions.
diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
@@ -0,0 +1,32 @@
+name: Node.js CI
+on:
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  ci:
+    name: Lint / Build / Test
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [12.x]
+
+    steps:
+      - name: Checkout Source Files
+        uses: actions/checkout@v2
+
+      - name: Use Node.js v${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Start database
+        uses: supercharge/[email protected]
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Run Tests
+        run: npm run test-local-or-ci
diff --git a/american-british-translator/package.json b/american-british-translator/package.json
@@ -5,7 +5,7 @@
   "main": "server.js",
   "scripts": {
     "start": "nodemon server.js",
-    "test": "mocha --timeout 5000 --require @babel/register --recursive --ui tdd tests/"
+    "test": "mocha --timeout 5000 --require @babel/register --recursive --exit --ui tdd tests/"
   },
   "dependencies": {
     "@babel/core": "^7.11.6",

diff --git a/anonymous-message-board/sample.env b/anonymous-message-board/sample.env
@@ -1,3 +1,3 @@
 PORT=
-DB_URI=
+DB_URI="mongodb://localhost:27017/message-board"
 # NODE_ENV=test
diff --git a/anonymous-message-board/tests/2_functional-tests.js b/anonymous-message-board/tests/2_functional-tests.js
@@ -48,6 +48,8 @@ suite('Functional Tests', function() {
         chai.request(server)
         .get('/api/threads/fcc-test')
         .end(function(err, res) {
+          testId = res.body[0]._id;
+          testId2 = res.body[1]._id;
           assert.equal(res.status, 200);
           assert.isArray(res.body);
           assert.isBelow(res.body.length, 11);
@@ -56,12 +58,8 @@ suite('Functional Tests', function() {
           assert.property(res.body[0], 'bumped_on');
           assert.property(res.body[0], 'text');
           assert.property(res.body[0], 'replies');
-          assert.property(res.body[0], 'reported');
-          assert.property(res.body[0], 'delete_password');
           assert.isArray(res.body[0].replies);
           assert.isBelow(res.body[0].replies.length, 4);
-          testId = res.body[0]._id;
-          testId2 = res.body[1]._id;
           done();
         });
       });
@@ -141,11 +139,7 @@ suite('Functional Tests', function() {
           assert.property(res.body, 'bumped_on');
           assert.property(res.body, 'text');
           assert.property(res.body, 'replies');
-          assert.property(res.body, 'delete_password');
-          assert.property(res.body, 'reported');
           assert.isArray(res.body.replies);
-          assert.property(res.body.replies[0], 'delete_password');
-          assert.property(res.body.replies[0], 'reported');
           assert.equal(res.body.replies[0].text, 'a reply'+testText);
           done();
         });

diff --git a/build-a-pinterest-clone/package.json b/build-a-pinterest-clone/package.json
@@ -5,7 +5,7 @@
   "main": "server.js",
   "scripts": {
     "start": "node server.js",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "wait-port -t 10000 3000"
   },
   "keywords": [],
   "author": "",

diff --git a/build-a-pinterest-clone/sample.env b/build-a-pinterest-clone/sample.env
@@ -1,5 +1,5 @@
-GITHUB_KEY=
-GITHUB_SECRET=
-DB_URI=
+GITHUB_KEY="foo"
+GITHUB_SECRET="bar"
+DB_URI="mongodb://localhost:27017/pinterest"
 APP_URL=
 NODE_ENV=
diff --git a/chart-the-stock-market/package.json b/chart-the-stock-market/package.json
@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "start": "node index.js",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "wait-port -t 10000 3000"
   },
   "author": "",
   "license": "ISC",

diff --git a/exercise-tracker/models/users.js b/exercise-tracker/models/users.js
@@ -6,7 +6,7 @@ const Users = new Schema({
     type: String, 
     required: true,
     unique: true,
-    maxlength: [20, 'username too long']
+    maxlength: [30, 'username too long']
   }
 });