Updated data processing and added initial details dashboard. #476
Conversation
|
@utsab I resolved the merge conflict. In the api_processor.js file in the formattedStudentData() function I had changed a property name (changed 'name' to 'blockName') and added a property to the getSuperBlockJsons(superblockURLS) function which I thought would be needed for the details page in this PR. You should be able to see/test the updated changes in a Codespace now. Let me know if there's any issues, or if you have any optimization suggestions. |
| let dashboardObjs = createDashboardObject(superBlockJsons); | ||
|
|
||
| // console.log('DDASHBOARD OBJS ===>', dashboardObjs) | ||
| let studentData = await getIndividualStudentData(studentEmail); |
There was a problem hiding this comment.
ISR should be used for the student data API response. This will allow us to avoid merging the data, and simply update the respective UI elements.
| let mergedDashboardData = []; | ||
|
|
||
| // reshape data to pass into UI | ||
| allCurriculumData.forEach(superblockData => { |
There was a problem hiding this comment.
lines 13-35: Let's remove this functionality to API processor an a function we utilize inside this file. Something like: updatedAllStudentCurriculumData(email). Then we can call this function and add the arguement for email inside this file. This should also prevent us from passing props (lines 129-132) inside Details Board from ./dashboard/v2/details/[id]/[studentemail].js
| </div> | ||
|
|
||
| <DetailsBoard | ||
| studentCurriculumData={studentCurriculumData} |
There was a problem hiding this comment.
we no longer need to pass props here since this is being imported from API processor
There was a problem hiding this comment.
We will still need props here because getServerSideProps() is what gives us access to data stored on the server, which is needed as the reference/parameters for the utility functions in api_processor.js. Even though functions from api_processr.js can be called in the other components, it is still necessary to fetch the data on the server first - and we need getServerSideProps() + context.params for this.
Checklist:
Update index.md)