jpegtran replaced with mozjpeg #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should pin dependencies in the future to prevent such breaking changes. |
|
@kevinmu17 any idea regarding foundation/foundation-cli#131? |
I found no details regarding this. Please provide additional information. |
|
I've reverted the changes as this definitely breaks. There is probably some build issue regarding jpegtran on your computer. Please check the output when you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jpegtran is no longer available. mozjpeg is the replacement. This fixes the errors when opening a new project after the command
$ foundation watchfoundation/foundation-sites#12113 < sorry, this was the wrong place to drop the issue, but here is more information if needed!