Fix version parsing in git #1757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `setup.py`, the date and time of the last commit is determined using `git log`, but fails to take into account that users may have enabled `log.showSignature` in their global git config. If this option is true and a commit is signed, it breaks the parsing of the git output. As a result, the package fails to build, because the version number is invalid. By just using the last line of the git output, we ensure that the signature is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
setup.py, the date and time of the last commit is determined usinggit log, but fails to take into account that users may have enabledlog.showSignaturein their global git config. If this option is true and a commit is signed, it breaks the parsing of the git output. As a result, the package fails to build, because the version number is invalid.By just using the last line of the git output, we ensure that the signature is ignored.
This fixes #1756.