Pin golangci-lint version #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldemailly
added a commit
to grol-io/grol
that referenced
this pull request
Aug 23, 2024
Same as fortio/workflows#67 (need to figure cross org share actually rather than copy-pasta)
asha-oss
approved these changes
Aug 23, 2024
|
nvm this one is good it's the grol one that's bad |
ldemailly
added a commit
to grol-io/grol
that referenced
this pull request
Aug 23, 2024
* Pin linter version Same as fortio/workflows#67 (need to figure cross org share actually rather than copy-pasta) * Fix the nolintlint now that gosec is fixed and the fix in linters 1.60.3 * Update .github/workflows/gochecks.yml
ccoVeille
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending golangci/golangci-lint-action#1091
Will avoid future breakages without code change or go version changes like we had with gosec int conversions