Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean golangci-lint configuration #37

Merged
merged 1 commit into from
May 21, 2024
Merged

Clean golangci-lint configuration #37

merged 1 commit into from
May 21, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 21, 2024

tips:

golangci-lint config verify --config golangci.yml

@ldemailly
Copy link
Member

Thanks a lot for cleaning up our config! greatly appreciated! of note, just filled #38

But I tested on fortio/fortio's and it worked

WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.  
WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.19) of your project is lower than Go 1.22 
WARN [linters_context] intrange: this linter is disabled because the Go version (1.19) of your project is lower than Go 1.22 

I suppose I should maybe also eventually remove execinquery but for now despite archive I think it's fine

Thanks again

@ldemailly ldemailly merged commit 38f8a15 into fortio:main May 21, 2024
4 of 5 checks passed
@ldez ldez deleted the feat/clean-golangci-lint-config branch May 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants