Skip to content

Commit

Permalink
Fix mnd still existing (#95)
Browse files Browse the repository at this point in the history
* Fix mnd still existing

* update golangci-lint- version
ldemailly authored Nov 12, 2024
1 parent 482d659 commit 8dbbe82
Showing 4 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gochecks.yml
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ jobs:
if: matrix.os == 'ubuntu-latest'
uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # pin@v6
with:
version: v1.61.0
version: v1.62.0
- name: Install Git Bash
run: |
choco install git
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ validate:
echo "golangci-lint found, running validation..."; \
golangci-lint version; \
golangci-lint config verify --config golangci.yml || exit 1; \
golangci-lint run --config golangci.yml || exit 1; \
else \
echo "golangci-lint not found, skipping validation."; \
fi
1 change: 1 addition & 0 deletions golangci.yml
Original file line number Diff line number Diff line change
@@ -79,6 +79,7 @@ linters:
# Redundant ones:
- gofmt # we use gofumpt
# Weird/bad ones:
- mnd
- wsl
- nlreturn
- gochecknoinits
9 changes: 8 additions & 1 deletion testing/workflow_test/main.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
// Just to minimally exercise some of the go actions
package main

import "fortio.org/scli"
import (
"runtime"

"fortio.org/log"
"fortio.org/scli"
)

func main() {
scli.ServerMain()
_, file, _, ok := runtime.Caller(2)
log.Infof("Just mnd check: %v %v", file, ok)
}

0 comments on commit 8dbbe82

Please sign in to comment.