Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list(datareducers) logic for deeper recursion #288

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix list(datareducers) logic for deeper recursion #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7001e3
Fix list(datareducers) logic for deeper recursion
alhom Oct 4, 2024
6fb7fcb
cleanup
alhom Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pyVlsv/vlsvreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ def __check_datareducer(self, name, reducer):
else:
in_vars = self.check_variable(var)

reducer_ok = reducer_ok and in_vars
# reducer_ok = reducer_ok and in_vars
if in_vars:
continue

Expand All @@ -589,10 +589,11 @@ def __check_datareducer(self, name, reducer):
reducer = reducer_reg[var]
except:
pass
if reducer is None: # Not in variables not in datareducers, break
reducer_ok = False
break

reducer_ok = reducer_ok and self.__check_datareducer(var, reducer)
else: # Not in variables not in datareducers, break
reducer_ok = False
break

if not reducer_ok: break

Expand Down
Loading