Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass an error message to the failure node #6181

Merged
merged 9 commits into from
Feb 3, 2025

improve code quality

3ed4177
Select commit
Loading
Failed to load commit list.
Merged

Pass an error message to the failure node #6181

improve code quality
3ed4177
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 19, 2025 in 1s

76.54% of diff hit (target 37.02%)

View this Pull Request on Codecov

76.54% of diff hit (target 37.02%)

Annotations

Check warning on line 776 in flytepropeller/pkg/controller/nodes/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/executor.go#L771-L776 

Added lines #L771 - L776 were not covered by tests

Check warning on line 172 in flytepropeller/pkg/controller/nodes/subworkflow/subworkflow.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/subworkflow/subworkflow.go#L172 

Added line #L172 was not covered by tests

Check warning on line 15 in flytepropeller/pkg/utils/assert/literals.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/utils/assert/literals.go#L14-L15 

Added lines #L14 - L15 were not covered by tests

Check warning on line 21 in flytepropeller/pkg/utils/assert/literals.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/utils/assert/literals.go#L20-L21 

Added lines #L20 - L21 were not covered by tests

Check warning on line 51 in flytepropeller/pkg/utils/assert/literals.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/utils/assert/literals.go#L50-L51 

Added lines #L50 - L51 were not covered by tests

Check warning on line 59 in flytepropeller/pkg/utils/assert/literals.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/utils/assert/literals.go#L58-L59 

Added lines #L58 - L59 were not covered by tests
View more details on Codecov