Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align flux diff skipping with kustomize-controller #5176

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

YvanGuidoin
Copy link
Contributor

Fixes: #5163

Following fluxcd/pkg#862

@stefanprodan
Copy link
Member

Can you please rebase and have a single commit

@YvanGuidoin YvanGuidoin force-pushed the diff-dry-run-skipping branch from 72e6a77 to 3a5863a Compare February 6, 2025 12:38
@YvanGuidoin YvanGuidoin force-pushed the diff-dry-run-skipping branch from 3a5863a to 960f72f Compare February 6, 2025 12:43
@stefanprodan stefanprodan changed the title fix: align flux diff skipping with kustomize-controller fix: align flux diff skipping with kustomize-controller Feb 9, 2025
@stefanprodan stefanprodan added the area/diff Diff related issues and pull requests label Feb 9, 2025
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @YvanGuidoin 🏅

@stefanprodan stefanprodan merged commit dcc4251 into fluxcd:main Feb 9, 2025
8 checks passed
@YvanGuidoin YvanGuidoin deleted the diff-dry-run-skipping branch February 9, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diff Diff related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flux diff ignores kustomize.toolkit.fluxcd.io/ssa annotations
2 participants