[FLORA-794] Replace the usage of datalog with Haskell for category normalisation #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchoutri
requested changes
Feb 4, 2025
| @@ -83,11 +76,6 @@ COPY --chown=${USER} scripts/.zshrc /home/$USER/.zshrc | |||
| COPY --chown=${USER} cabal.project flora.cabal cabal.project.freeze ./ | |||
| RUN cabal build --only-dependencies -j | |||
|
|
|||
| # compile Souffle source files | |||
| COPY --chown=${USER} Makefile ./ | |||
There was a problem hiding this comment.
We still need the Makefile. :)
| @@ -145,9 +145,6 @@ docker-enter: ## Enter the docker environment | |||
| start-tmux: ## Start a Tmux session with hot code reloading | |||
| ./scripts/start-tmux.sh | |||
|
|
|||
| soufflé: ## Generate C++ files from the Soufflé Datalog definitions | |||
There was a problem hiding this comment.
You must remove all the other references to this Makefile rule in other rules.
| @@ -395,7 +395,6 @@ constraints: any.Cabal ==3.10.3.0, | |||
| any.some ==1.0.6, | |||
| some +newtype-unsafe, | |||
| any.sop-core ==0.5.0.2, | |||
| any.souffle-haskell ==4.0.0, | |||
There was a problem hiding this comment.
Can you re-generate the file as a whole? This will also remove unneeded transitive dependencies.
There was a problem hiding this comment.
We should keep this file, it's just that we're going to use the new functions now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Contributor checklist
changelog.d./docs/docsif a public feature has a behaviour change