Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 404 message for advisories more generic #807

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Make the 404 message for advisories more generic #807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/web/FloraWeb/Pages/Templates/Packages.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@

showAll :: Target -> Maybe Version -> Namespace -> PackageName -> FloraHTML
showAll target mVersion namespace packageName = do
let resource = case target of

Check warning on line 387 in src/web/FloraWeb/Pages/Templates/Packages.hs

View workflow job for this annotation

GitHub Actions / Backend_tests (9.6.6, ubuntu-latest) 

Pattern match(es) are non-exhaustive
Dependents -> Links.dependentsPage namespace packageName (PositiveUnsafe 1)
Dependencies -> Links.dependenciesPage namespace packageName (fromJust mVersion)
Versions -> Links.versionsPage namespace packageName
Expand Down Expand Up @@ -572,7 +572,7 @@
advisoriesListing :: Vector PackageAdvisoryPreview -> FloraHTML
advisoriesListing advisoryPreviews =
if Vector.null advisoryPreviews
then p_ [] "No advisories found for this package."
then p_ [] "No advisories found."
else div_ [class_ "advisory-list"] $ do
div_ [class_ "advisory-list__head"] $ do
div_ [class_ "advisory-list__header"] "ID"
Expand Down
Loading