Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL uniformisation for namespaces prefix (/@ vs /&40) (#601) #765

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

fel-mazo
Copy link
Contributor

Hello,

I made the changes described in the ticket.
Let me know if there is something I can improve.

attached, screenshots of what changed

image
image
image
image

@tchoutri
Copy link
Contributor

@fel-mazo Thank you very much! I think the mkURL function may also cause problems: https://github.com/flora-pm/flora-server/blob/development/src/web/FloraWeb/Components/PaginationNav.hs#L44-L54

@fel-mazo
Copy link
Contributor Author

yes defo ! will look into it asap

@TixieSalander TixieSalander added frontend Frontend concerns Improvement labels Oct 14, 2024
@tchoutri tchoutri added the Hackathon Tickets that can be started or done during a Hackathon label Oct 19, 2024
@fel-mazo
Copy link
Contributor Author

I just updated my branch, I also tried to reorganize my changes a bit and put everything in the Links module, let me know if the names are fine as they are or if it would be better to change them.

@fel-mazo fel-mazo force-pushed the development branch 2 times, most recently from 68d64b8 to 9200fab Compare October 20, 2024 14:10
@tchoutri tchoutri added the merge me Tell Mergify bot to merge the PR label Nov 8, 2024
@mergify mergify bot merged commit 54fd56b into flora-pm:development Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend concerns Hackathon Tickets that can be started or done during a Hackathon Improvement merge me Tell Mergify bot to merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants