Lots of updates, mostly focusing on the CI and build system #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove concurrency
do everything in tnm
…actions-20230821-130214 Convert cooljeanius/scotty to GitHub Actions
attempting to debug
more attempting to debug
more Linux packages
I'd have to learn how rpcgen(1) works in order to fix this correctly
look in another place for Tcl
no longer need to locate Tcl
ok now let's debug THIS build failure
replace sudo with explicit dist specification
let's get a bit more output here
ignore more logs
set some additional Homebrew-related environment variables
add ca-certificates
add some extra verbosity to brew
try speeding up the build with caching and parallelization
let's make that global, not osx
more tweaking
some additional debugging messages
only do "-Icompat" on linux
let's see about skipping <config.h> on Linux
a few more cpan package changes
ok, so it looks like those gems just really won't work...
override CFLAGS everywhere when actually building
add flag to find rpc headers
need rpc headers in 1 more place
ignore errors
add some more flags
try increasing codeql coverage
ok so maybe it isn't actually called "net-snmp"?
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ons/checkout-4 Bump actions/checkout from 3 to 4
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ub/codeql-action-3 Bump github/codeql-action from 2 to 3
resuna
approved these changes
Jan 22, 2024
Some still remain, though
update brew dependencies
oops, I forgot libtirpc doesn't install on macOS
try looking 1 more place for tcl on macOS
reformat so it's readable enough for me to figure out where I need to edit to fix that latest failure
|
Actually never mind; apparently pull requests from master are a bad idea; let me try from another branch... |
|
OK, so PR #15 now replaces this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been messing around in my fork of scotty for awhile and figured I'd try submitting a PR back upstream. Changes here include:
If some of these changes aren't wanted, that's ok, you can just close this PR, and I'll continue to maintain the changes in my fork.
(Edit: if you do decide that you want these changes, I would recommend squashing before merging, as there are a lot of individual commits)