Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modals in overview #27

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: modals in overview #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {WindowActorTracker} from './manager/effect_manager.js';
import {connections} from './utils/connections.js';
import {constants} from './utils/constants.js';
import {_log, stackMsg} from './utils/log.js';
import {init_settings, uninit_settings, settings} from './utils/settings.js';
import {init_settings, settings, uninit_settings} from './utils/settings.js';
import * as UI from './utils/ui.js';

// types, which will be removed in output
Expand Down Expand Up @@ -117,7 +117,10 @@ export default class RoundedWindowCornersReborn extends Extension {
);
has_rounded_corners = UI.ShouldHasRoundedCorners(window, cfg);
}
if (!(has_rounded_corners && shadow)) {
if (
!(has_rounded_corners && shadow) ||
window.has_attached_dialogs()
Copy link
Owner

@flexagoon flexagoon Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you need to disable the shadow on the attached dialog itself, shouldn't this be is_attached_dialog()?

This would only disable the shadow for the dialog and not for the parent window. I'm not at my laptop right now though, so I can't test that out, lmk if that doesn't work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this patch isn't disabling shadow on attached dialog, it disables shadows for windowPreview (src).

windowPreview is a container for each window in the overview. They are responsible for drawing icons and handling DND. Each windowPreview contains Meta.Window which it represents but attached dialogs don't deserve their own windowPreview so they are added to the parent's windowPreview.

You might ask "But why we need additional effects for each window preview element in the overview?". The answer is this screenshot.

Screenshot from 2024-06-28 20-57-21

Even if a window actor has a shadow on the desktop, in the overview it's barely visible. And as noted in the comments of the function override, that I edited, since GNOME 43 window actors with effects will become blurry.

Coming back to the bug mentioned in #18, it basically happens, because adding wide or tall attached dialog to the windowPreview enlarges it which adds transparent spots on the windowPreview. But internally windowPreview's actor is still a rectangular box. Applying shadow effect simply highlights this.

) {
return;
}

Expand Down