Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 Integrate login button in Agents UI (Rev 5) #461

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

heldrida
Copy link
Member

Why?

Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.

⚠️ Put back from #453

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting

How?

  • Deprecate custom authentication in-website to favour @fleek-platform/login-button

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Complete user auth flow

login-button-auth-flow-cross-page--enc.mp4

Projects persistent state

user-projects-persistent-state--enc.mp4

Login button flow (from 2025-01-21 17h23 GMT)

login-button-flow-rev-21jan2k251721--enc.mp4

Login

login-logout-journey-demo--enc.mp4

Project switch

project-drop-down-switch-demo--enc.mp4

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 6b5bf6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@heldrida heldrida marked this pull request as ready for review January 23, 2025 21:31
@heldrida heldrida merged commit 2db09f9 into develop Jan 23, 2025
5 checks passed
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Put back from #453

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Complete user auth flow

https://github.com/user-attachments/assets/72cf6408-0a76-49b0-9d96-eb5f0fb93001

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Put back from #453

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Complete user auth flow

https://github.com/user-attachments/assets/72cf6408-0a76-49b0-9d96-eb5f0fb93001

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant