Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eliza): add plugins support #459

Merged
merged 9 commits into from
Jan 27, 2025
Merged

feat(eliza): add plugins support #459

merged 9 commits into from
Jan 27, 2025

Conversation

victorgaard
Copy link
Contributor

@victorgaard victorgaard commented Jan 23, 2025

Why?

  • Added supported plugins to constants
  • Added plugin dropdown to builder form
  • Added validation for the final characterfile json
  • Added better error visualization in review page
collapsed.errors.mov
plugin-support.mov

👆 disregard errors in review page from this demo

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: e778879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@victorgaard victorgaard changed the title feat(eliza): add plugins support (builder form feat(eliza): add plugins support Jan 23, 2025
@victorgaard victorgaard marked this pull request as ready for review January 23, 2025 20:46
@nlc616 nlc616 requested review from bcamarneiro and mbcse January 24, 2025 00:15
@nlc616
Copy link
Contributor

nlc616 commented Jan 24, 2025

Only comment so far after watching the full video is that that error section at :49 seems unworkably long

Screenshot 2025-01-23 at 7 23 14 PM

how can we make this error text more human-readable?

bcamarneiro
bcamarneiro previously approved these changes Jan 24, 2025
Copy link
Contributor

@bcamarneiro bcamarneiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

bcamarneiro
bcamarneiro previously approved these changes Jan 27, 2025
@victorgaard victorgaard merged commit c68b03b into develop Jan 27, 2025
5 checks passed
@victorgaard victorgaard deleted the feat/plugins-support branch January 27, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants