-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🤖 Integrate login button in Agents UI (Rev 2) #447
chore: 🤖 Integrate login button in Agents UI (Rev 2) #447
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
lgtm |
4ce93d7
2c59a93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
## Why? Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting ## How? - Deprecate custom authentication in-website to favour @fleek-platform/login-button ## Tickets? - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) ## Contribution checklist? - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing ## Security checklist? - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) ## References? Optionally, provide references such as links ## Preview? > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting - Deprecate custom authentication in-website to favour @fleek-platform/login-button - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) Optionally, provide references such as links > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting - Deprecate custom authentication in-website to favour @fleek-platform/login-button - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) Optionally, provide references such as links > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting - Deprecate custom authentication in-website to favour @fleek-platform/login-button - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) Optionally, provide references such as links > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting - Deprecate custom authentication in-website to favour @fleek-platform/login-button - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) Optionally, provide references such as links > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting - Deprecate custom authentication in-website to favour @fleek-platform/login-button - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) Optionally, provide references such as links > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.⚠️ Reverted due to a dynamic.xyz CORS issue, e.g. d5ac309 will re-attempt after troubleshooting - Deprecate custom authentication in-website to favour @fleek-platform/login-button - [PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [ ] Document filename is named after the slug - [ ] You've reviewed spelling using a grammar checker - [ ] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing - [x] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) - [ ] The Components are escaping output (to prevent XSS) Optionally, provide references such as links > Projects persistent state https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509 > Login button flow (from 2025-01-21 17h23 GMT) https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5 > Login https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4 > Project switch https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Why?
Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.
How?
Tickets?
Contribution checklist?
build
command runs locallySecurity checklist?
References?
Optionally, provide references such as links
Preview?
user-projects-persistent-state--enc.mp4
login-button-flow-rev-21jan2k251721--enc.mp4
login-logout-journey-demo--enc.mp4
project-drop-down-switch-demo--enc.mp4