Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 Integrate login button in Agents UI (Rev 2) #447

Merged
merged 43 commits into from
Jan 22, 2025

Conversation

heldrida
Copy link
Member

@heldrida heldrida commented Jan 20, 2025

Why?

Integrate login button in Agents UI and deprecation of in-website authentication and cookie handling.

How?

  • Deprecate custom authentication in-website to favour @fleek-platform/login-button

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Projects persistent state

user-projects-persistent-state--enc.mp4

Login button flow (from 2025-01-21 17h23 GMT)

login-button-flow-rev-21jan2k251721--enc.mp4

Login

login-logout-journey-demo--enc.mp4

Project switch

project-drop-down-switch-demo--enc.mp4

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: 2c59a93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

angarita-dev
angarita-dev previously approved these changes Jan 20, 2025
Copy link
Collaborator

@angarita-dev angarita-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bcamarneiro
Copy link
Contributor

lgtm

victorgaard
victorgaard previously approved these changes Jan 21, 2025
angarita-dev
angarita-dev previously approved these changes Jan 21, 2025
@heldrida heldrida dismissed stale reviews from angarita-dev and victorgaard via 4ce93d7 January 22, 2025 10:52
@heldrida heldrida marked this pull request as ready for review January 22, 2025 13:27
victorgaard
victorgaard previously approved these changes Jan 22, 2025
bcamarneiro
bcamarneiro previously approved these changes Jan 22, 2025
@heldrida heldrida dismissed stale reviews from bcamarneiro and victorgaard via 2c59a93 January 22, 2025 13:40
Copy link
Contributor

@nemanjafleek nemanjafleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@heldrida heldrida merged commit c73d788 into develop Jan 22, 2025
5 checks passed
heldrida added a commit that referenced this pull request Jan 22, 2025
heldrida added a commit that referenced this pull request Jan 23, 2025
## Why?

Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

## How?

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

## Tickets?

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

## Contribution checklist?

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

## Security checklist?

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

## References?

Optionally, provide references such as links

## Preview?

> Projects persistent state


https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)


https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login


https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch


https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
heldrida added a commit that referenced this pull request Jan 23, 2025
bcamarneiro pushed a commit that referenced this pull request Jan 23, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
bcamarneiro pushed a commit that referenced this pull request Jan 24, 2025
Integrate login button in Agents UI and deprecation of in-website
authentication and cookie handling.

⚠️ Reverted due to a dynamic.xyz CORS issue, e.g.
d5ac309
will re-attempt after troubleshooting

- Deprecate custom authentication in-website to favour
@fleek-platform/login-button

-
[PLAT-1991](https://linear.app/fleekxyz/issue/PLAT-1991/integration-fleek-platformlogin-button-in-agents-ui-initial-website)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] Document filename is named after the slug
- [ ] You've reviewed spelling using a grammar checker
- [ ] For documentation, guides or references, you've tested the
commands and steps
- [x] You've done enough research before writing

- [x] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)
- [ ] The Components are escaping output (to prevent XSS)

Optionally, provide references such as links

> Projects persistent state

https://github.com/user-attachments/assets/127c3cfa-db84-4f02-bc1d-58deb5db0509

> Login button flow (from 2025-01-21 17h23 GMT)

https://github.com/user-attachments/assets/2b5d794b-5371-4b1c-9d65-ab4946c416c5

> Login

https://github.com/user-attachments/assets/de9f9df4-6592-45f4-be84-a1d04d2f92e4

> Project switch

https://github.com/user-attachments/assets/6ac7c6da-29ee-453b-be19-236fc2f6ce5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants