Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eliza): add new users to newsletter (beehiiv) #445

Merged
merged 10 commits into from
Jan 21, 2025

Conversation

victorgaard
Copy link
Contributor

@victorgaard victorgaard commented Jan 17, 2025

Why?

  • Adds new signed up users to our newsletter provider (Beehiiv)
  • Provide a modal to consent to being subscribed to the newsletter. For wallet users, we display an input to add the email address.

Email flow:

email.flow.mov

Wallet flow:

wallet.flow.mov

How?

  • Done A (replace with a breakdown of the steps)
  • Done B
  • Done C

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 701fdbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@victorgaard victorgaard force-pushed the feat/add-new-users-to-beehiiv branch from c738ecc to 3a16b87 Compare January 20, 2025 13:47
Copy link
Member

@heldrida heldrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should be given control to decide interest in subscribing to newsletter. At the moment its automatically subscribed.

@victorgaard victorgaard changed the title feat(eliza): add new users to newsletter (beehiiv) / prompt wallet users to provide email feat(eliza): add new users to newsletter (beehiiv) Jan 20, 2025
@victorgaard victorgaard requested a review from heldrida January 20, 2025 22:22
@victorgaard victorgaard marked this pull request as ready for review January 20, 2025 22:22
heldrida
heldrida previously approved these changes Jan 21, 2025
@victorgaard victorgaard merged commit 111e6e8 into develop Jan 21, 2025
4 of 5 checks passed
@victorgaard victorgaard deleted the feat/add-new-users-to-beehiiv branch January 21, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants