Handle 404 status code in the proxyResponse. (#8119)

* Handle 404 status code in the proxyResponse. * Changelog --------- Co-authored-by: Leonardo Ortiz <[email protected]>
firebase · Jan 31, 2025 · 60f3cd7 · 60f3cd7
1 parent 468000f
commit 60f3cd7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+- Fixes issue with custom 404 pages not being returned in Next.js in the emulator (#8035).
diff --git a/src/frameworks/utils.ts b/src/frameworks/utils.ts
@@ -208,7 +208,12 @@ export function simpleProxy(hostOrRequestHandler: string | RequestHandler) {
         originalRes.end();
       });
     } else {
-      const proxiedRes = proxyResponse(originalReq, originalRes, next);
+      const proxiedRes = proxyResponse(originalReq, originalRes, () => {
+        // This next function is called when the proxied response is a 404
+        // In that case we want to let the handler to use the original response
+        void hostOrRequestHandler(originalReq, originalRes, next);
+      });
+
       await hostOrRequestHandler(originalReq, proxiedRes, next);
     }
   };
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Fixes issue with custom 404 pages not being returned in Next.js in the emulator (#8035).