Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTER-19] SPA improvements #77

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Conversation

TheUnderScorer
Copy link
Contributor

This PR introduces suggested improvements from the related issue, except for this one:

Maybe a getter/method like cacheDepth for getting the number of cached fp identifications that are on the client..

because it would mean we had to introduce breaking changes to the cache interface. If we still want to introduce it, we'll need to discuss the implementation first.

@TheUnderScorer TheUnderScorer requested a review from ilfa November 2, 2023 10:10
@TheUnderScorer TheUnderScorer self-assigned this Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
96.67% (-0.44% 🔻)
174/180
🟢 Branches
96.19% (+0.04% 🔼)
101/105
🟢 Functions
84.48% (+0.55% 🔼)
49/58
🟢 Lines
96.49% (-0.46% 🔻)
165/171
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 client.ts
97.33% (-1.2% 🔻)
95.29% (+1.54% 🔼)
94.44% (+0.69% 🔼)
97.33% (-1.2% 🔻)

Test suite run success

46 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 29bb11f

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 96.66 96.19 84.48 96.49
🟢  src 97.89 95.4 78.26 97.75
🟢   client.ts 97.33 95.29 94.44 97.33 21,122
🟢   global.ts 100 100 100 100
🟢   index.ts 100 100 0 100
🟢  src/cache 95.29 100 88.57 95.12
🟢   cache-local-storage.ts 92.85 100 100 92.85 23
🟢   cache-manager.ts 100 100 100 100
🟢   cache-memory.ts 100 100 100 100
🟢   cache-session-storage.ts 92.85 100 100 92.85 33
🔴   cache-stub.ts 33.33 100 0 33.33 10-16
🟢   index.ts 100 100 100 100
🟢   shared.ts 100 100 100 100

src/client.ts Outdated Show resolved Hide resolved
ilfa
ilfa previously approved these changes Nov 14, 2023
Copy link
Member

@ilfa ilfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made as we discussed, looks good.
@JuroUhlar what do you think about readme?

README.md Outdated Show resolved Hide resolved
@JuroUhlar
Copy link
Contributor

Made as we discussed, looks good. @JuroUhlar what do you think about readme?

It looks good! I made one suggestion.
I also noticed this PR too late and merged my other readme PR, creating merge conflicts, sorry about that. @TheUnderScorer I can resolve the conflicts in this PR in you like, can I do that?

@TheUnderScorer
Copy link
Contributor Author

Sure @JuroUhlar, feel free to resolve the conflicts, thanks! 😄

Co-authored-by: Juraj Uhlar <[email protected]>
Copy link

This PR will create a minor release 🚀

1.3.0 (2023-11-17)

Features

  • add cacheHit flag to response that indicates if it was retrieved from cache (c101318)
  • introduce getVisitorDataFromCache and isInCache options (a9aa598)
  • support passing loadOptions in .init() method as well (f772512)

@JuroUhlar
Copy link
Contributor

Sure @JuroUhlar, feel free to resolve the conflicts, thanks! 😄

@TheUnderScorer Done!

@TheUnderScorer TheUnderScorer merged commit c898404 into main Nov 22, 2023
4 checks passed
@TheUnderScorer TheUnderScorer deleted the feature/INTER-19-spa-improvements branch November 22, 2023 11:37
@ilfa
Copy link
Member

ilfa commented Nov 22, 2023

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilfa ilfa added the released label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants