-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTER-19] SPA improvements #77
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success46 tests passing in 2 suites. Report generated by 🧪jest coverage report action from 29bb11f Show full coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made as we discussed, looks good.
@JuroUhlar what do you think about readme?
It looks good! I made one suggestion. |
Sure @JuroUhlar, feel free to resolve the conflicts, thanks! 😄 |
Co-authored-by: Juraj Uhlar <[email protected]>
…s' into feature/INTER-19-spa-improvements
@TheUnderScorer Done! |
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR introduces suggested improvements from the related issue, except for this one:
because it would mean we had to introduce breaking changes to the cache interface. If we still want to introduce it, we'll need to discuss the implementation first.