Skip to content

Commit

Permalink
Merge pull request #60 from fingerprintjs/feat/improve-prettier-for-m…
Browse files Browse the repository at this point in the history
…d-files

Feat: Decrease prettier printWidth for .md files
  • Loading branch information
JuroUhlar authored May 24, 2024
2 parents 643240f + 74a7d5b commit 93a5cc9
Show file tree
Hide file tree
Showing 18 changed files with 4,062 additions and 2,670 deletions.
5 changes: 5 additions & 0 deletions .changeset/large-houses-kiss.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@fingerprintjs/prettier-config-dx-team': minor
---

Set printWidth of markdown files to 80
6 changes: 3 additions & 3 deletions .github/workflows/analyze-commits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ jobs:
message: |
## Wrong commit message format detected
We use [Semantic Commit Messages](https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716) in our project.
> **Warning**
> Probably you forgot to activate local git hooks.
Run the next command in the project root to activate local hooks:
```sh
sh ./install_hooks.sh
```
More info you can find in [job logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
### Commitlint Errors
${{ steps.commitlint_formatted_results.outputs.formatted }}
Expand All @@ -85,7 +85,7 @@ jobs:
with:
header: Commitlint
hide: true
hide_classify: "OUTDATED"
hide_classify: 'OUTDATED'
release-notes-comment:
name: Generate release notes preview
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
target_branch:
required: true
type: string
description: "Branch to create a pr for"
description: 'Branch to create a pr for'
tag_name:
required: false
type: string
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs-and-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
required: false
default: false
type: boolean
description: "Skip the documentation generation step."
description: 'Skip the documentation generation step.'

jobs:
generate-docs-and-coverage:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-server-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
tools: composer:v2

- name: 'Prepare project'
if: ${{ inputs.prepare-command != '' }}
if: ${{ inputs.prepare-command != '' }}
run: ${{ inputs.prepare-command }}

- name: 'Get token for the GitHub App'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release-typescript-project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,3 @@ jobs:
GITHUB_TOKEN: ${{ inputs.appId != '' && steps.app-token.outputs.token || secrets.GH_RELEASE_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
HUSKY: 0

2 changes: 1 addition & 1 deletion .github/workflows/reset-prerelease-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:

jobs:
create-branch-and-force-push:
name: "Create branch from main and force push"
name: 'Create branch from main and force push'
runs-on: ubuntu-latest
environment: production
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-status-reporting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
cmd:
- echo "Success!"
- exit 1
os: [ ubuntu-latest, macos-latest ]
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Execute command
Expand Down
34 changes: 17 additions & 17 deletions .releaserc.js
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
module.exports = {
"dryRun": true,
"branches": [
"main",
dryRun: true,
branches: [
'main',
{
"name": "release-*",
"prerelease": true,
name: 'release-*',
prerelease: true,
},
],
"plugins": [
plugins: [
[
"@semantic-release/commit-analyzer",
'@semantic-release/commit-analyzer',
{
"config": "@fingerprintjs/conventional-changelog-dx-team",
"releaseRules": "@fingerprintjs/conventional-changelog-dx-team/release-rules"
}
config: '@fingerprintjs/conventional-changelog-dx-team',
releaseRules: '@fingerprintjs/conventional-changelog-dx-team/release-rules',
},
],
[
"@semantic-release/release-notes-generator",
'@semantic-release/release-notes-generator',
{
"config": "@fingerprintjs/conventional-changelog-dx-team",
}
config: '@fingerprintjs/conventional-changelog-dx-team',
},
],
[
"@semantic-release/exec",
'@semantic-release/exec',
{
"prepareCmd": "echo \"Prepare to release ${nextRelease.version}\""
}
prepareCmd: 'echo "Prepare to release ${nextRelease.version}"',
},
],
]
],
}
98 changes: 49 additions & 49 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion commitlint.config.cjs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = { extends: ['@fingerprintjs/commit-lint-dx-team'] };
module.exports = { extends: ['@fingerprintjs/commit-lint-dx-team'] }
1 change: 0 additions & 1 deletion packages/commit-lint-dx-team/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ To use this preset in your project, add the following configuration to your proj
module.exports = {
extends: ['@fingerprintjs/commit-lint-dx-team'],
}

```

## License
Expand Down
17 changes: 9 additions & 8 deletions packages/conventional-changelog-dx-team/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,19 @@ module.exports = {
[
'@semantic-release/commit-analyzer',
{
'config': '@fingerprintjs/conventional-changelog-dx-team',
'releaseRules': '@fingerprintjs/conventional-changelog-dx-team/release-rules'
}
config: '@fingerprintjs/conventional-changelog-dx-team',
releaseRules:
'@fingerprintjs/conventional-changelog-dx-team/release-rules',
},
],
[
'@semantic-release/release-notes-generator',
{
'config': '@fingerprintjs/conventional-changelog-dx-team',
}
config: '@fingerprintjs/conventional-changelog-dx-team',
},
],
]
};
],
}
```

## Commit Examples
Expand All @@ -53,7 +54,7 @@ module.exports = {
#### Breaking change (major)

```
feat: upgrade runtime to Node 20
feat: upgrade runtime to Node 20
BREAKING CHANGE: use node 20
```
Expand Down
8 changes: 8 additions & 0 deletions packages/prettier-config-dx-team/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,12 @@ module.exports = {
bracketSameLine: false,
arrowParens: 'always',
svelteSortOrder: 'options-scripts-markup-styles',
overrides: [
{
files: '*.md',
options: {
printWidth: 80,
},
},
],
}
12 changes: 2 additions & 10 deletions packages/tsconfig-dx-team/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,9 @@ To use this preset in your project, add the following configuration to your proj
// Don't forget to specify jsx for react projects - https://www.typescriptlang.org/docs/handbook/jsx.html
"jsx": "react-jsx"
},
"files": [
"./src/index.ts"
],
"exclude": [
"dist",
"node_modules",
"**/*.test.ts"
]
"files": ["./src/index.ts"],
"exclude": ["dist", "node_modules", "**/*.test.ts"]
}


```

## License
Expand Down
Loading

0 comments on commit 93a5cc9

Please sign in to comment.